✅ Deploy Preview for calva-docs ready!

Name	Link
🔨 Latest commit	bf3d442
🔍 Latest deploy log	https://app.netlify.com/sites/calva-docs/deploys/66faab1ae5541f0008422eea
😎 Deploy Preview	https://deploy-preview-2643--calva-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Thanks for helping with making Calva better! 🙏

The change looks fine. I have added a small suggestion for CHANGELOG wording.

We do not merge changes that the author hasn't tested. I am assuming you have tested it, and are reading the checklist item as meaning “added automated tests”, which is not what it is about. Please confirm that you have tested the change.

Also for the formatting and linting, we appreciate that this is confirmed. If you are running the build task, these two things are taken care of, and you can check the outputs of the task to confirm. If you are not running the build task, you can check here for the PR build. It is tested in CI, so if CI says the build is cool, the formatting and linting passes: https://app.circleci.com/pipelines/github/BetterThanTomorrow/calva

I ran npm run eslint on my laptop and can confirm that it returns no errors if launched with the ESLint version declared in the package.json (8.8.0). Actually the first time I ran it using ESLint 9.x.x (9.11.1 if I remember correctly) and it returned a bunch of errors, but it's because they changed a couple of things in the config file and removed support for the --ext flag in the CLI.

I also ran npm run format-prettier on my laptop and it returns no errors.

As you mentioned in issue #2642 (comment), one could simply declare calva.projectRootsSearchExclude in .vscode/settings.json. That's how I tested that my "change" was working.

"calva.projectRootsSearchExclude": [
    ".cpcache",
    ".devenv",
    ".git",
    ".vscode"
  ]

I haven't yet tested it on my local version of Calva though. I have just started reading how to run Calva in development mode.

I have just realized that in docs/site/customizing-jack-in-and-connect.md this image should be updated, or maybe replaced with this JSON.

[
  "bower_components",
  ".bzr",
  ".cache",
  ".ccls-cache",
  ".clangd",
  ".classpath",
  "*.code-search",
  ".cpcache",
  "_darcs",
  ".devenv",
  ".DS_Store",
  ".ensime_cache",
  ".eunit",
  "flow-typed",
  "_FOSSIL_",
  ".fslckout",
  ".git",
  ".hg",
  ".idea",
  ".joyride",
  "node_modules",
  ".pijul",
  ".project",
  ".shadow-cljs",
  ".stack-work",
  ".svn",
  "target",
  ".tox",
  ".vscode"
]

We could run a small shell script or Babashka script before running mkdocs build -d docs/site. Something like this:

cat package.json | jq '.contributes.configuration[0].properties."calva.projectRootsSearchExclude".default' > docs/site/projectRootsSearchExclude.json

I have just realized that in docs/site/customizing-jack-in-and-connect.md this image should be updated

Good point. It is better to remove the image, I think. I can do that later.

I haven't yet tested it on my local version of Calva though. I have just started reading how to run Calva in development mode.

Cool. Holler when you've gotten that tested and we'll be merging this. Thanks again for the help with this!

@jackdbd did you ever get to test this in your local dev env?